impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5537: Retry RPC on somes exceptions with SSL connection
Date Tue, 20 Jun 2017 23:23:58 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-5537: Retry RPC on somes exceptions with SSL connection
......................................................................


Patch Set 4:

(3 comments)

Thanks for doing this. It would be good to get a secure stress run with this patch too.

http://gerrit.cloudera.org:8080/#/c/7229/2/be/src/rpc/thrift-util.cc
File be/src/rpc/thrift-util.cc:

PS2, Line 208: // "TTransportException: Transport not open" is from TSSLSocket.cpp
I don't think this comment is necessary. This could be from TSocket.cpp too.


http://gerrit.cloudera.org:8080/#/c/7229/2/be/src/runtime/client-cache.h
File be/src/runtime/client-cache.h:

Line 328:       return Status(TErrorCode::RPC_GENERAL_ERROR, ExceptionMsg(e));
Not from this change, but I think we should set client_is_unrecoverable_=false before returning
here. Else, we'll be destroying a "good" connection unnecessarily.


http://gerrit.cloudera.org:8080/#/c/7229/2/tests/custom_cluster/test_rpc_exception.py
File tests/custom_cluster/test_rpc_exception.py:

PS2, Line 46: execute_query
Not from this change, but change to execute_test_query().

execute_query() is another function implemented by the ImpalaTestSuite and we'd rather avoid
confusion.


-- 
To view, visit http://gerrit.cloudera.org:8080/7229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8243d4cac93c453e9396b0e24f41e147c8637b8c
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message