impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5537: Retry RPC on somes exceptions with SSL connection
Date Tue, 20 Jun 2017 22:34:44 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5537: Retry RPC on somes exceptions with SSL connection
......................................................................


Patch Set 2:

(6 comments)

looks good. I'll have another think about it. Could you ask Sailesh to take a look as well,
please?

http://gerrit.cloudera.org:8080/#/c/7229/2/be/src/catalog/catalog-service-client-wrapper.h
File be/src/catalog/catalog-service-client-wrapper.h:

Line 25: class CatalogServiceClientWrapper: public CatalogServiceClient {
nit: space before :


http://gerrit.cloudera.org:8080/#/c/7229/2/be/src/rpc/thrift-util.cc
File be/src/rpc/thrift-util.cc:

PS2, Line 207: ||
Should this really be && ?


http://gerrit.cloudera.org:8080/#/c/7229/2/be/src/runtime/client-cache-types.h
File be/src/runtime/client-cache-types.h:

PS2, Line 23: CatalogServiceClientWrapper
replace line 38 with this one.


http://gerrit.cloudera.org:8080/#/c/7229/2/be/src/runtime/client-cache.h
File be/src/runtime/client-cache.h:

PS2, Line 243: bool* retry_is_safe = NULL
let's not do it now, but I think we should get rid of this parameter in favour of an indicator
that it's ok to retry recv (and have this method call RetryRpcRecv() itself). Leave a comment,
if you agree?


PS2, Line 319: bool send_done = false;
nit: move inside try block


http://gerrit.cloudera.org:8080/#/c/7229/2/be/src/statestore/statestore-service-client-wrapper.h
File be/src/statestore/statestore-service-client-wrapper.h:

PS2, Line 28:  
space really needed? here and below


-- 
To view, visit http://gerrit.cloudera.org:8080/7229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8243d4cac93c453e9396b0e24f41e147c8637b8c
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message