impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikramjeet Vig (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5240: Allow configuration of number of disk I/O threads based on disk type
Date Tue, 20 Jun 2017 22:27:32 GMT
Bikramjeet Vig has posted comments on this change.

Change subject: IMPALA-5240: Allow configuration of number of disk I/O threads based on disk
type
......................................................................


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/7232/1//COMMIT_MSG
Commit Message:

PS1, Line 7: IMPALA-5240: Allow configuration of number of disk I/O threads based
           : on disk type
> long line, please keep to 90chars
Done


Line 20: Tested manually. Unfortunately, there is no way using DiskIoMgr class
> did you see how we test num_threads_per_disk in disk-io-mgr-test ? it'd be 
Unfortunately there are no tests that check if num_threads_per_disk has been set correctly.
Also, I have not been able to find any indicators in behavior of this class that we can check
when these parameters are changed.
@Tim, do you have any thoughts on this? Thanks!


http://gerrit.cloudera.org:8080/#/c/7232/1/be/src/runtime/disk-io-mgr.cc
File be/src/runtime/disk-io-mgr.cc:

PS1, Line 47: num_threads_per_rotational_disk
> Maybe io_threads instead of threads_ to be more specific. We can leave the 
Done


PS1, Line 50: num_threads_per_flash_disk
> Not your change but we probably shouldn't call this "flash", since that's a
Done


http://gerrit.cloudera.org:8080/#/c/7232/1/be/src/runtime/disk-io-mgr.h
File be/src/runtime/disk-io-mgr.h:

PS1, Line 637:   ///  - threads_per_rotational_disk: number of read threads to create per
rotational
             :   ///    disk. This is also the max queue depth.
             :   ///  - threads_per_flash_disk: number of read threads to create per flash
disk. This is
             :   ///    also the max queue depth.
             :   DiskIoMgr(int num_disks, int threads_per_disk, int min_buffer_size,
             :       int max_buffer_size, int threads_per_rotational_disk = 0,
             :       int threads_per_flash_disk = 0)
> I believe this constructor only exists for the backend tests. I think we sh
I think the best thing would be to remove them because I don't think we have use for any test
that is specifically aimed at the type of disk used.


-- 
To view, visit http://gerrit.cloudera.org:8080/7232
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I094aff3747104104fe0465d73dcdbef5d9892f7c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message