impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikramjeet Vig (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2546: Fix handling of invalid timezones
Date Tue, 20 Jun 2017 21:14:47 GMT
Bikramjeet Vig has uploaded a new patch set (#2).

Change subject: IMPALA-2546: Fix handling of invalid timezones
......................................................................

IMPALA-2546: Fix handling of invalid timezones

The bug was that when invalid timezones were passed to udfs
"to_utc_timestamp" and "from_utc_timestamp", a warning was shown and
original values were returned. The correct behaviour is that an error
should be returned instead.

Testing:
Added expression tests for both udfs

Change-Id: I587a16bb8e835a6eea02e1f87fd4033686e84d0f
---
M be/src/exprs/expr-test.cc
M be/src/exprs/timestamp-functions.cc
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
3 files changed, 16 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/7216/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7216
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I587a16bb8e835a6eea02e1f87fd4033686e84d0f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>

Mime
View raw message