impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5536: Fix TCLIService thrift compilation on Hive 2
Date Tue, 20 Jun 2017 18:33:32 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5536: Fix TCLIService thrift compilation on Hive 2
......................................................................


Patch Set 2:

(1 comment)

Joe - is this rebased on the Sentry version revert patch? If not, I think this might fail
GVO.

http://gerrit.cloudera.org:8080/#/c/7231/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

Line 2812:       Pair<String, String> statsTaskParam =
nit: long line


-- 
To view, visit http://gerrit.cloudera.org:8080/7231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e1477993ee3ccddd236609efec7bb23f20a7b66
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message