impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5537: Retry RpcRecv on recv timeout exception for SSL connection
Date Tue, 20 Jun 2017 17:36:31 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-5537: Retry RpcRecv on recv timeout exception for SSL connection
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7229/1//COMMIT_MSG
Commit Message:

PS1, Line 24: After this change, we will still fail the RPC if there is
            : any error in the send part of a RPC with secure connection.
> I'm still slightly worried about this. Our client cache could previously po
Your concern is valid. I noticed the following in the log message of IMPALA-5537:

f27a50000001d #in-flight=27 status=RPC_GENERAL_ERROR: RPC Error: Client for <some-host>:22000
hits an unexpected exception: TTransportException: Transport not open, type: N6apache6thrift9transport19TTransportExceptionE

That's why I think the flag suggested in thrift-util.cc is needed as the exception thrown
by TSSLSocket.cpp cannot help us tell between whether send has completed or not when the exception
occurs.


-- 
To view, visit http://gerrit.cloudera.org:8080/7229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8243d4cac93c453e9396b0e24f41e147c8637b8c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message