impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5537: Retry RpcRecv on recv timeout exception for SSL connection
Date Tue, 20 Jun 2017 16:09:20 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5537: Retry RpcRecv on recv timeout exception for SSL connection
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7229/1/be/src/rpc/thrift-util.cc
File be/src/rpc/thrift-util.cc:

PS1, Line 209: Called write on non-open socket"
> It seems that we still didn't handle the case of send failure for failed co
I agree, that would be safer - then we can be certain what phase the exceptions get thrown
in.


-- 
To view, visit http://gerrit.cloudera.org:8080/7229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8243d4cac93c453e9396b0e24f41e147c8637b8c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message