impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5333: [DOCS] Document Impala ADLS support
Date Tue, 20 Jun 2017 16:04:08 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-5333: [DOCS] Document Impala ADLS support
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7175/1/docs/topics/impala_adls.xml
File docs/topics/impala_adls.xml:

PS1, Line 261:         You point
Maybe just an imperative "Point" ?


PS1, Line 279:         For example,
Because the paragraph starting at L269 mentions a database with a LOCATION, I expected this
example also to have a database with a LOCATION. I was confused that it didn't.

One solution would be to swap the ordering of this example so that it comes before the paragraph
that starts on L269. Swapping the two would also make the example starting at L285 fit in
nicely, since it *does* use a database with a LOCATION.


-- 
To view, visit http://gerrit.cloudera.org:8080/7175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5a98217741e5d540d9874e9b30e36f01644ef14
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message