impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1474: Add a metric for running queries
Date Tue, 20 Jun 2017 03:53:54 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-1474: Add a metric for running queries
......................................................................


Patch Set 1:

(4 comments)

Just a few nits in addition to Bharath's comments.

http://gerrit.cloudera.org:8080/#/c/7228/1/be/src/util/impalad-metrics.cc
File be/src/util/impalad-metrics.cc:

PS1, Line 110: IntGauge* ImpaladMetrics::NUM_FRAGMENTS_IN_FLIGHT = NULL;
move below


http://gerrit.cloudera.org:8080/#/c/7228/1/be/src/util/impalad-metrics.h
File be/src/util/impalad-metrics.h:

PS1, Line 45:   /// Number of queries currently running on this server
            :   /// queries
1L


PS1, Line 168:   static IntGauge* NUM_FRAGMENTS_IN_FLIGHT;
move below


http://gerrit.cloudera.org:8080/#/c/7228/1/tests/hs2/test_fetch.py
File tests/hs2/test_fetch.py:

PS1, Line 30: @pytest.mark.execute_serially
do you have a ballpark idea how long this increases total test time?


-- 
To view, visit http://gerrit.cloudera.org:8080/7228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41bc88d0e91427ca2fd70136dc6e06fa7a2663da
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message