impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5530: fix compilation against Sentry
Date Tue, 20 Jun 2017 02:41:27 GMT
Tim Armstrong has submitted this change and it was merged.

Change subject: IMPALA-5530: fix compilation against Sentry
......................................................................


IMPALA-5530: fix compilation against Sentry

* SentryUserException moved packages as a result of the SENTRY-1205
  change. If we just catch the Exception superclass Impala should
  compile against both versions of the API.
* SentryPolicyServiceClient.close() throws java.lang.Exception

Change-Id: Ie08831dd3df3861f34de75b26eecb9182641aaa9
Reviewed-on: http://gerrit.cloudera.org:8080/7222
Reviewed-by: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Tested-by: Tim Armstrong <tarmstrong@cloudera.com>
---
M fe/src/main/java/org/apache/impala/util/SentryPolicyService.java
1 file changed, 14 insertions(+), 11 deletions(-)

Approvals:
  Thomas Tauber-Marshall: Looks good to me, but someone else must approve
  Tim Armstrong: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie08831dd3df3861f34de75b26eecb9182641aaa9
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message