impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-1474: Add a metric for running queries
Date Tue, 20 Jun 2017 01:10:31 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-1474: Add a metric for running queries

Patch Set 1:

Commit Message:

PS1, Line 10: Queries waiting to be
            : unregistered are included in the count.
Should this be exposed as a separate metric as well? Reason being we have seen a couple of
bugs in the part due to this part contending on client_exec_state_map_lock_ and also the session_lock.
May be it helps supportability.
File be/src/service/

Line 791:   ImpaladMetrics::NUM_QUERIES_IN_FLIGHT->Increment(1L);
Looks like there is some discrepancy on the term IN_FLIGHT in the code. For ex: SetQueryInFlight()
is only called *after* the Execute() returns and fragments are started async whereas in the
context of this patch any query still blocked inside Execute() is also counted under NUM_QUERIES_IN_FLIGHT
(Ex: those blocked in metadata loading). So might be good to clear that up.

Line 965:   ImpaladMetrics::NUM_QUERIES_IN_FLIGHT->Increment(-1L);
Should this be moved to after L986 when the session state is cleaned up?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I41bc88d0e91427ca2fd70136dc6e06fa7a2663da
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <>
Gerrit-Reviewer: Bharath Vissapragada <>
Gerrit-HasComments: Yes

View raw message