impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4874: Increase the maximum KRPC message size to 4GB
Date Mon, 19 Jun 2017 20:59:25 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4874: Increase the maximum KRPC message size to 4GB
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5887/1/be/src/kudu/rpc/serialization.cc
File be/src/kudu/rpc/serialization.cc:

PS1, Line 119: buf.size(
Is it reasonable to DCHECK(BitUtil::IsNonNegative32Bit(buf.size()) here given the 4GB limit
imposed ?


http://gerrit.cloudera.org:8080/#/c/5887/1/be/src/statestore/statestore-test.cc
File be/src/statestore/statestore-test.cc:

Line 49:   TestSubscriber(int id, RpcMgr* rpc_mgr, const TNetworkAddress& statestore_address,
int32_t port)
nit: long line.


-- 
To view, visit http://gerrit.cloudera.org:8080/5887
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb97dd4604548c404278fe8094db2e419021a7c3
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message