impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8
Date Mon, 19 Jun 2017 20:36:49 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

Patch Set 6:


Looks good. Just have minor comments then I'm ready to +1. I think Alex or Dimitris should
still have a pass over and confirm it makes sense ot them.
File fe/src/main/cup/sql-parser.cup:

PS6, Line 1485: HashMap

PS6, Line 1528: Map

PS6, Line 1695:     

PS6, Line 1908: HashMap
File fe/src/main/java/org/apache/impala/analysis/

PS6, Line 444: Map
LinkedHashMap? I don't feel as strongly about this one since it doesn't cross module boundaries.
File fe/src/main/java/org/apache/impala/analysis/

Line 179:   // LinkeHashSet where applicable to preserve the iteration order and make the
File fe/src/main/java/org/apache/impala/analysis/

PS6, Line 171: getSources

PS6, Line 176: getTargets
Maybe getOrderedTargets()?

PS6, Line 194: Map

Line 342:     for (String target: Sets.newTreeSet(targets)) {
It might be more efficient to use Guava's ImmutableSortedSet here and above. It gives you
back a Set<> backed by a sorted array. I don't feel that strongly but it seems like
it would be easy enough.
File fe/src/main/java/org/apache/impala/analysis/

PS6, Line 187: HashMap

PS6, Line 211: HashMap

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad8e1dccec3a51293a109c420bd2b88b9d1e0625
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Taras Bobrovytsky <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message