impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5431: Remove redundant path exists check during table load
Date Mon, 19 Jun 2017 20:31:19 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-5431: Remove redundant path exists check during table load
......................................................................


Patch Set 1:

(1 comment)

Alex, I did a quick audit of the exists() checks in HdfsTable and none of them seem to be
duplicates/redundant. Could you confirm which ones you refer to in your last comment? Ofcourse
we can cache that check per table/partition but I don't think we should do that and instead
have a runtime check.

http://gerrit.cloudera.org:8080/#/c/7095/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java:

PS1, Line 1486: FileSystem fs = partDirPath.getFileSystem(CONF);
> remove
Looking into it, actually StorageDescriptor is not at all needed, we are just passing it around
without using it. I'll check its implications and remove it in a follow up patch. Raised IMPALA-5533


-- 
To view, visit http://gerrit.cloudera.org:8080/7095
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id10ecf64ea2eda2d0f9299c0aa371933eca22281
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message