impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vincent Tran (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5315 Cast to timestamp fails for YYYY-M-D format
Date Sat, 17 Jun 2017 17:37:47 GMT
Vincent Tran has posted comments on this change.

Change subject: IMPALA-5315 Cast to timestamp fails for YYYY-M-D format
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7009/3/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

Line 2216:       TimestampValue::Parse("2001-01-21 00:00:00"));
> Sorry for the delayed response, I missed this question.
Generating it on-the-fly is an excellent idea. Done.
I've also added a few more cases so that it's inline with the current default templates.
yyyy-[M]M-[d]d[T][H]H:[m]m:[s]s[.S]


-- 
To view, visit http://gerrit.cloudera.org:8080/7009
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9a184a09d7e7783f04d47588537612c2ecec28f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vincent Tran <vttran@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vttran@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message