impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikramjeet Vig (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC
Date Sat, 17 Jun 2017 00:05:35 GMT
Bikramjeet Vig has posted comments on this change.

Change subject: IMPALA-3504: UDF for current timestamp in UTC
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/7203/2/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

PS2, Line 5192: "now()";
> this message isn't going to be very clear later
Done


PS2, Line 5193: utc_timestamp(
> same
Done


PS2, Line 5201: now
> local_time
Done


PS2, Line 5202: TimestampValue
> can you make this const, then make a separate TimestampValue which is to be
Done


PS2, Line 5187: const string stmt = "select now(), utc_timestamp()";
              :   vector<FieldSchema> result_types;
              :   Status status = executor_->Exec(stmt, &result_types);
              :   EXPECT_TRUE(status.ok()) << "stmt: " << stmt << "\nerror:
" << status.GetDetail();
              :   DCHECK(result_types.size() == 2);
              :   EXPECT_EQ(TypeToOdbcString(TYPE_TIMESTAMP), result_types[0].type) <<
"now()";
              :   EXPECT_EQ(TypeToOdbcString(TYPE_TIMESTAMP), result_types[1].type) <<
"utc_timestamp()";
              :   string result_row;
              :   status = executor_->FetchResult(&result_row);
              :   EXPECT_TRUE(status.ok()) << "stmt: " << stmt << "\nerror:
" << status.GetDetail();
              :   vector<string> result_cols;
              :   boost::split(result_cols, result_row, boost::is_any_of("\t"));
              :   // To ensure this fails if columns are not tab separated
              :   DCHECK(result_cols.size() == 2);
              :   const TimestampValue now = ConvertValue<TimestampValue>(result_cols[0]);
              :   TimestampValue utc_timestamp = ConvertValue<TimestampValue>(result_cols[1]);
              :   utc_timestamp.UtcToLocal();
              :   EXPECT_EQ(utc_timestamp, now);
> can you wrap this in a set of braces to (1) make the code associated with t
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7203
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I969fc805922f2bb9c8101e84f85ff2cc3b1b6729
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message