impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5481: Clarify RowDescriptor ownership
Date Fri, 16 Jun 2017 20:06:21 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5481: Clarify RowDescriptor ownership
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7206/2/be/src/runtime/data-stream-recvr.h
File be/src/runtime/data-stream-recvr.h:

Line 134:   /// Row schema, copied from the caller of CreateRecvr().
> No longer accurate
Done


http://gerrit.cloudera.org:8080/#/c/7206/2/be/src/runtime/row-batch.h
File be/src/runtime/row-batch.h:

Line 428:   const RowDescriptor* row_desc_;
> Maybe comment on what the expected lifetime of row_desc_ is? Alternatively 
I thought about adding them to an object pool - but the exec nodes themselves are already
allocated from a pool and so that seemed like unnecessary doubling-down. 

Added a comment to here, ExecNode::row_desc() and RowDescriptor - let me know if that seems
like enough coverage (it's hard to find the right place to talk about widespread ownership
concerns sometimes).


-- 
To view, visit http://gerrit.cloudera.org:8080/7206
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fc39170f775581d406b6a97445046f508d8d75f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message