impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe McDonnell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5488: Fix handling of exclusive HDFS file handles
Date Fri, 16 Jun 2017 17:40:17 GMT
Joe McDonnell has posted comments on this change.

Change subject: IMPALA-5488: Fix handling of exclusive HDFS file handles
......................................................................


Patch Set 1:

(2 comments)

Rebased to latest

http://gerrit.cloudera.org:8080/#/c/7181/1/be/src/runtime/disk-io-mgr-scan-range.cc
File be/src/runtime/disk-io-mgr-scan-range.cc:

Line 304:       // Destroy the file handle and remove it from the cache
> Nit: period at end for consistency?
Done


Line 351:       // Destroy the file handle and remove it from the cache
> Nit: period at end for consistency?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c03696984285cc9ce463edd969c5149cd83a861
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message