impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.
Date Fri, 16 Jun 2017 17:06:08 GMT
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-4622: Add ALTER COLUMN statement.
......................................................................


Patch Set 6:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/6955/5/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java:

Line 48:   private final boolean isDropDefault_;
> remove blank line
Done


Line 113:     if (column == null) {
> Instead of this you can pass the Column into Table.isClusteringColumn() on 
Done


http://gerrit.cloudera.org:8080/#/c/6955/5/testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test
File testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test:

Line 497: # set a non-nullable column's default to null, which is equivalent to 'drop default'
> also explain that this is equivalent do DROP DEFAULT which is consistent wi
Done


http://gerrit.cloudera.org:8080/#/c/6955/5/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:

Line 366:       pytest.skip("Only runs in exhaustive to reduce core time.")
> Only runs in exhaustive to reduce core time.
Done


Line 388:             assert "encoding %s not supported for type" % e in str(err)
> Doesn't this result in a PK conflict? I suggest adding a new row in every i
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2e8bd65342b79644a0fdcd925e6f17797e89ad6
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message