impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC
Date Fri, 16 Jun 2017 02:06:55 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC
......................................................................


Patch Set 13:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5720/13/be/src/rpc/rpc.h
File be/src/rpc/rpc.h:

PS13, Line 66: Sets the timeout for TCP writes and reads.
Isn't it actually end-to-end timeout of the async RPC according to RpcController::set_timeout().


PS13, Line 175: err
err != nullptr


http://gerrit.cloudera.org:8080/#/c/5720/11/be/src/statestore/statestore.cc
File be/src/statestore/statestore.cc:

PS11, Line 75: "The number of threads available to service "
             :                                              "incoming RPC requests"
nit: why is the indentation of the comment different from the lines above ?


-- 
To view, visit http://gerrit.cloudera.org:8080/5720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbf12b9ecd71d26d239d31c19b487175194c766
Gerrit-PatchSet: 13
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Juan Yu <jyu@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message