impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.
Date Thu, 15 Jun 2017 21:48:49 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
......................................................................


Patch Set 13:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5715/14/be/src/common/config.h.in
File be/src/common/config.h.in:

Line 22: /// This is a template that is populated by CMake with config information
Mind adding a comment that these flags are set in be/CMakeList.txt ?


http://gerrit.cloudera.org:8080/#/c/5715/13/be/src/kudu/util/minidump.cc
File be/src/kudu/util/minidump.cc:

PS13, Line 96: namespace kudu {
> We could just remove it from CMakeLists.txt (we already do that for another
Removing it sounds good to me.


-- 
To view, visit http://gerrit.cloudera.org:8080/5715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8da798ee55506d6f969416b17c191eb03cb215f5
Gerrit-PatchSet: 13
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message