impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5315 Cast to timestamp fails for YYYY-M-D format
Date Thu, 15 Jun 2017 03:50:53 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5315 Cast to timestamp fails for YYYY-M-D format
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7009/3/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

Line 2216:       TimestampValue::Parse("2001-01-21 00:00:00"));
> So looks like both of these formats should be supported:
Sorry for the delayed response, I missed this question.

That's going to result in a lot of stamped out formats though, right? But I guess we don't
have a great alternative given the way the code works today. Though you'll have to basically
parse the input format in order to match it up since many of them will have the same lengths,
so it seems like there should be a better way where we generate the parse information on-the-fly.
But if you don't see a good way to do that efficiently, I guess stamping them out is okay.


-- 
To view, visit http://gerrit.cloudera.org:8080/7009
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9a184a09d7e7783f04d47588537612c2ecec28f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vincent Tran <vttran@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vttran@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message