impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Donghui Xu (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5492: Fix incorrect newline character in the LDAP message within impala-shell introduction
Date Wed, 14 Jun 2017 01:12:31 GMT
Donghui Xu has posted comments on this change.

Change subject: IMPALA-5492: Fix incorrect newline character in the LDAP message within impala-shell
introduction
......................................................................


Patch Set 3:

(2 comments)

I have resolved the problems you mentioned. Please review again. Thanks.

http://gerrit.cloudera.org:8080/#/c/7166/2//COMMIT_MSG
Commit Message:

Line 7: IMPALA-5492: Fix incorrect newline character in the LDAP message within impala-shell
introduction
> nit: Space after the jira key, something like "IMPALA-5492: <subject>". (Th
Done


PS2, Line 9: The introduction has redundant '\' in impala-shell when using LDAP.
           : 
           : I fix this issue by removing extraneous '\' in introduction when
           : impala-shell using LDAP.
> May be reword to "Remove extraneous '\' .."?  Looks like you are not removi
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30c601ab255a4882260f7be23b5763ef8ec76d28
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu.donghui@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu.donghui@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message