impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5492: Fix incorrect newline character in the LDAP message within impala-shell introduction
Date Wed, 14 Jun 2017 01:10:00 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5492: Fix incorrect newline character in the LDAP message within impala-shell
introduction
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7166/3/shell/impala_shell.py
File shell/impala_shell.py:

PS3, Line 1391: +
nit: can you remove this while you're here as well?


-- 
To view, visit http://gerrit.cloudera.org:8080/7166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30c601ab255a4882260f7be23b5763ef8ec76d28
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu.donghui@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message