impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5333: [DOCS] Document Impala ADLS support
Date Tue, 13 Jun 2017 21:58:57 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-5333: [DOCS] Document Impala ADLS support
......................................................................


Patch Set 1:

(3 comments)

I've read through roughly half of impala_adls.xml and noticed a few things.

http://gerrit.cloudera.org:8080/#/c/7175/1/docs/topics/impala_adls.xml
File docs/topics/impala_adls.xml:

Line 154:       
L154 has trailing white space. It's best to remove trailing white space from text that is
under revision control, whether it be prose, code, or markup.


PS1, Line 156:         As an alternative, specify the credentials in environment variables
before starting the <cmdname>impalad</cmdname>
             :         daemon.
Is it possible to list a mapping between core-site.xml settings above and environment variable
names?


Line 219:           <li>
This is still empty. :)


-- 
To view, visit http://gerrit.cloudera.org:8080/7175
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5a98217741e5d540d9874e9b30e36f01644ef14
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message