impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5487: Fix race in RuntimeProfile::toThrift()
Date Mon, 12 Jun 2017 20:05:36 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-5487: Fix race in RuntimeProfile::toThrift()
......................................................................


Patch Set 1:

(1 comment)

Thank you for the comments. I uploaded PS2, where I removed the .reserve().

http://gerrit.cloudera.org:8080/#/c/7154/1/be/src/util/runtime-profile.cc
File be/src/util/runtime-profile.cc:

PS1, Line 764: children_.size()
> Yes, I left it there since it doesn't change correctness and I assumed in t
I removed.


-- 
To view, visit http://gerrit.cloudera.org:8080/7154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fad4ee2eee1f73e387c1e90a3db265b19b3a0c6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message