impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "yu feng (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5016: Simplify COALESCE() in SimplifyConditionalsRule.
Date Sun, 11 Jun 2017 15:33:35 GMT
yu feng has posted comments on this change.

Change subject: IMPALA-5016: Simplify COALESCE() in SimplifyConditionalsRule.
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7015/4//COMMIT_MSG
Commit Message:

Line 7: IMPALA-5016: Simplify COALESCE() in SimplifyConditionalsRule.
> Long lines here, and commit msg needs some polish.
Done


Line 13: COALESCE(<partition-slotref>, a, b) -> <partition-slotref>,
> replace with
Done


http://gerrit.cloudera.org:8080/#/c/7015/4/fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java
File fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java:

Line 143:         slotRef.getDesc().getParent().getTable().
> long lines
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0325a9e437261b15313bbdf2f22d83376a84b575
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: yu feng <hzfengyu@corp.netease.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: yu feng <hzfengyu@corp.netease.com>
Gerrit-HasComments: Yes

Mime
View raw message