impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR](asf-site) IMPALA-5470: Modernize links and instructions on download page
Date Fri, 09 Jun 2017 15:18:49 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-5470: Modernize links and instructions on download page
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7124/1/downloads.html
File downloads.html:

Line 189:                 <li>To check a SHA1 sum, run <code>sha1sum --check
> I think it can be a bit confusing that both sha sums use the same file exte
Agreed. Unfortunately, the sha1sums are already made and posted (2.7, 2.8, 2.9) and going
forward the sha512 sums should follow the ASF release policy, which says to use ".sha".


PS1, Line 189: SHA1
> macOS doesn't ship these binaries. Instead it comes with a shasum binary, t
I can add that. Could you also tell me how to do md5sum and sha512sum?

Alternately, we could make this improvement in a follow-on patch, authored by someone who
owns a mac.


-- 
To view, visit http://gerrit.cloudera.org:8080/7124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec680428cb7e0df3f831527218d296214eff5c7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message