impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule.
Date Fri, 09 Jun 2017 14:18:54 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule.
......................................................................


Patch Set 4:

(3 comments)

Final polish.

http://gerrit.cloudera.org:8080/#/c/7015/4//COMMIT_MSG
Commit Message:

Line 7: IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule.
Long lines here, and commit msg needs some polish.

I suggest as the title.

Simplify COALESCE() in SimplifyConditionalsRule.

Then you can copy+paste your comment from the simplifyCoalesceFunctionCallExpr() function
here which already describes everything. Please be sure to stay within the line limit.


Line 13: add some unit tests for SimplifyConditionalsRule with coalesce() function.
replace with

- added unit tests in ExprRewriteRulesTest


http://gerrit.cloudera.org:8080/#/c/7015/4/fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java
File fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java:

Line 143:         slotRef.getDesc().getParent().getTable().isClusteringColumn(slotRef.getDesc().getColumn()))
{
long lines


-- 
To view, visit http://gerrit.cloudera.org:8080/7015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0325a9e437261b15313bbdf2f22d83376a84b575
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: yu feng <hzfengyu@corp.netease.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: yu feng <hzfengyu@corp.netease.com>
Gerrit-HasComments: Yes

Mime
View raw message