impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update
Date Fri, 09 Jun 2017 00:46:43 GMT
Hello Dimitris Tsirogiannis, Alex Behm,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7121

to look at the new patch set (#2).

Change subject: IMPALA-5469: Fix exception when processing catalog update
......................................................................

IMPALA-5469: Fix exception when processing catalog update

In IMPALA-5355 patch, a regression was introduced where we end up
calling addCatalogObject on a CATALOG object type in the second pass
over the catalog objects because the CATALOG object is not considered
a top level object.

The issue is fixed by updating the top level objects in the first pass
and updating the non top level objects and the catalog object in the
second pass.

Testing:
- Verified by manually running "invalidate metadata" and checking that
  there is no exception in the impalad.INFO log file.
- No new tests were added because it is difficult and excessive to
  reproduce the issue in a test.

Change-Id: I7b8e7db2c679ea9bffd8863a3367aa3b94e4e1ed
---
M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
1 file changed, 9 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/7121/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7b8e7db2c679ea9bffd8863a3367aa3b94e4e1ed
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>

Mime
View raw message