impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR](asf-site) IMPALA-5470: Modernize links and instructions on download page
Date Fri, 09 Jun 2017 00:18:04 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-5470: Modernize links and instructions on download page
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7124/1/downloads.html
File downloads.html:

PS1, Line 189: SHA1
macOS doesn't ship these binaries. Instead it comes with a shasum binary, that takes the algorithm
as a parameter. You would run "shasum -a256 -c checkSumFile". We don't support building or
running Impala on macOS, but it may be helpful for people trying to verify the files on their
physical hardware, and some developers use Macs.


Line 189:                 <li>To check a SHA1 sum, run <code>sha1sum --check
I think it can be a bit confusing that both sha sums use the same file extension. Do we have
any control over how these files are named or do they have to end in .sha by convention?


-- 
To view, visit http://gerrit.cloudera.org:8080/7124
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibec680428cb7e0df3f831527218d296214eff5c7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message