impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext
Date Thu, 08 Jun 2017 23:16:24 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-4192: Disentangle Expr and ExprContext
......................................................................


Patch Set 19: Code-Review+2

(9 comments)

http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/exec/analytic-eval-node.h
File be/src/exec/analytic-eval-node.h:

Line 229:   /// Analytic functions and their evaluators.
ownership?


http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/exec/exec-node.cc
File be/src/exec/exec-node.cc:

Line 498: //   %eval_ptr = getelementptr inbounds %"class.impala::ScalarExprEvaluator"*, 
trailing


http://gerrit.cloudera.org:8080/#/c/5483/17/be/src/exec/exec-node.h
File be/src/exec/exec-node.h:

Line 290:   boost::scoped_ptr<MemPool> expr_mem_pool_;
> We were passing the expr_mem_tracker directly into the ExprContext so there
i guess it's going in the right direction :)


http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/exec/hbase-scan-node.cc
File be/src/exec/hbase-scan-node.cc:

Line 250:     if (EvalConjuncts(&conjunct_evals_[0], conjuncts_.size(), row)) {
.data()


http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/exec/hdfs-parquet-scanner.cc
File be/src/exec/hdfs-parquet-scanner.cc:

Line 1238:         if (ExecNode::EvalConjuncts(&evals[0], evals.size(), row)) {
.data()


http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/exec/partitioned-aggregation-node.cc
File be/src/exec/partitioned-aggregation-node.cc:

Line 1410: //   %input0 = call { i8, double } @GetSlotRef(%"class.impala::ScalarExprEvaluator"*

trailing


http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/exprs/scalar-expr-evaluator.cc
File be/src/exprs/scalar-expr-evaluator.cc:

Line 218:   for (int i = 0; i < evals.size(); ++i) {
single line


http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/runtime/data-stream-test.cc
File be/src/runtime/data-stream-test.cc:

Line 307: 	is_asc_, nulls_first_));
tab

can't you specify the initializer list inline, as in: .., {true}, {true})?

if that doesn't work, shouldn't vector<bool>{1, true} work?


http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/util/tuple-row-compare.h
File be/src/util/tuple-row-compare.h:

Line 141:   std::vector<int8_t> nulls_first_;
const& here as well?


-- 
To view, visit http://gerrit.cloudera.org:8080/5483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefdc9aeeba033355cb9497e3a5d2363627dcf2f3
Gerrit-PatchSet: 19
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message