impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4892: Session ID included in error message
Date Thu, 08 Jun 2017 18:53:58 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4892: Session ID included in error message
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

Looks good - please fix the long line, then I'll commit. Thanks!

http://gerrit.cloudera.org:8080/#/c/7054/3/be/src/service/impala-hs2-server.cc
File be/src/service/impala-hs2-server.cc:

Line 435:         return_val, Status(Substitute("Invalid session id: $0", PrintId(session_id))),
SQLSTATE_GENERAL_ERROR);
Nit: can you fix the long line? For readability, maybe split into two lines, one that creates
the string, one that returns the status.


-- 
To view, visit http://gerrit.cloudera.org:8080/7054
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I721951aaf2425da62e61d65150e462a83716b02e
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Steve Carlin <stevec@arcadiadata.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Steve Carlin <stevec@arcadiadata.com>
Gerrit-HasComments: Yes

Mime
View raw message