impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call
Date Thu, 08 Jun 2017 00:20:57 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-5388: Only retry RPC on lost connection in send call

Patch Set 10:

File be/src/rpc/

PS9, Line 194:  possible
> can you make this a static assert? Otherwise we might not hit this as early
File be/src/runtime/client-cache.h:

PS9, Line 297: std::s
> this should be std::string (I think some google header rudely uses std :/).

PS9, Line 298:  $0 
> nit: prefer "hit an" or "saw an"

PS9, Line 299: TNetwor
> TNetworkAddressToString(address_) (match the other exception messages, not 
File be/src/testutil/

PS9, Line 69: // by IsSendFailTException().
> it's unlikely in the extreme, but you could never take this branch if 1024 
File tests/custom_cluster/

PS9, Line 27: # This que
> can you comment to say that proper test coverage relies on sending Transmit

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I176975f2aa521d5be8a40de51067b1497923d09b
Gerrit-PatchSet: 10
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <>
Gerrit-Reviewer: Alan Choi <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-Reviewer: Juan Yu <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message