impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5455: test infra: default --cm-port based on --use-tls
Date Thu, 08 Jun 2017 00:06:07 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-5455: test infra: default --cm-port based on --use-tls
......................................................................


Patch Set 2:

(1 comment)

Thanks for the review, Matt. Good idea. Please see patch set 2.

http://gerrit.cloudera.org:8080/#/c/7107/1/tests/comparison/cli_options.py
File tests/comparison/cli_options.py:

PS1, Line 146:       help='The host name of the CM server.')
             :   # IMPALA-5455: --cm-port defaults to None so that --use-tls can 
> I've never actually seen CM use non-standard ports, i.e. never something be
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7dfa6c400687f3c5ccaf578fd4fb17dedd6eded
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message