impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5455: test infra: default --cm-port based on --use-tls
Date Thu, 08 Jun 2017 00:05:04 GMT
Hello David Knupp,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7107

to look at the new patch set (#2).

Change subject: IMPALA-5455: test infra: default --cm-port based on --use-tls
......................................................................

IMPALA-5455: test infra: default --cm-port based on --use-tls

This patch sets the default --cm-port (for the CM ApiResource
initialization) based on a new flag, --use-tls, which enables test infra
to talk to CM clusters with TLS enabled. It is still possible to set a
port override, but in general it will not be needed.

Reference:

https://cloudera.github.io/cm_api/epydoc/5.4.0/cm_api.api_client.ApiResource-class.html#__init__

Testing:

Connected both to TLS-disabled and TLS-enabled CM instances. Before this
patch, we would fail hard when trying to talk to the TLS-enabled CM
instance.

Change-Id: Ie7dfa6c400687f3c5ccaf578fd4fb17dedd6eded
---
M tests/comparison/cli_options.py
M tests/comparison/cluster.py
2 files changed, 31 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/7107/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie7dfa6c400687f3c5ccaf578fd4fb17dedd6eded
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>

Mime
View raw message