impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call
Date Wed, 07 Jun 2017 23:21:00 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5388: Only retry RPC on lost connection in send call

Patch Set 9: Code-Review+1


Thanks - I think this is a great improvement.
File be/src/rpc/

PS9, Line 194: DCHECK_EQ
can you make this a static assert? Otherwise we might not hit this as early (e.g. until we
run tests).
File be/src/runtime/client-cache.h:

PS9, Line 297: string
this should be std::string (I think some google header rudely uses std :/).

PS9, Line 298: hits
nit: prefer "hit an" or "saw an"

PS9, Line 299: client_
TNetworkAddressToString(address_) (match the other exception messages, not the log message
that was removed).
File be/src/testutil/

PS9, Line 69: if ((send_count.Load() / 1024) % 2 == 0) {
it's unlikely in the extreme, but you could never take this branch if 1024 sends happen between
lines 65 and 69. Maybe just cache the return from send_count.Add(1) and use it here?
File tests/custom_cluster/

PS9, Line 27: TEST_QUERY
can you comment to say that proper test coverage relies on sending TransmitData() > 1024

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I176975f2aa521d5be8a40de51067b1497923d09b
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <>
Gerrit-Reviewer: Alan Choi <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-Reviewer: Juan Yu <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message