impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5454: Work around template rendering bug in /memz
Date Wed, 07 Jun 2017 22:50:47 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5454: Work around template rendering bug in /memz
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7106/1/www/memz.tmpl
File www/memz.tmpl:

PS1, Line 72: jvm_total
> Reading the mustache parser code [1], looks like SECTION_START (#foo) and P
The # operator also does iteration:

  {{#foo}}bar{{/foo}}

will print 'bar' for every item in 'foo'. See "non-empty lists" in https://mustache.github.io/mustache.5.html.


-- 
To view, visit http://gerrit.cloudera.org:8080/7106
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f01a5cfd3c1c226532bab13895d922f05e94ee
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message