impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5454: Work around template rendering bug in /memz
Date Wed, 07 Jun 2017 22:47:18 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-5454: Work around template rendering bug in /memz
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7106/1/www/memz.tmpl
File www/memz.tmpl:

PS1, Line 72: jvm_total
Reading the mustache parser code [1], looks like SECTION_START (#foo) and PREDICATE_SECTION_START
(?foo) are evaluated in the same manner. Is my understanding correct?

If yes, wondering why we need the inner {{#jvm_total}} if we already have the outer {{?jvm_total}},
given it is evaluated only if jvm_total is set to a non-empty val?

[1] https://github.com/henryr/cpp-mustache/blob/master/mustache.cc


-- 
To view, visit http://gerrit.cloudera.org:8080/7106
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f01a5cfd3c1c226532bab13895d922f05e94ee
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message