impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary
Date Wed, 07 Jun 2017 04:56:39 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary

Patch Set 4:


Thanks, looks much nicer!
File be/src/service/

Line 1094:       << "or execution summary.";
File be/src/service/client-request-state.h:

Line 220:   Status CheckProfileAccess(const std::string& user);
const function?
File be/src/service/

Line 636: Status ImpalaServer::QueryStateRecord::CheckProfileAccess(const string& user)
What do you think of moving this into auth-util.h like the other function so it's obvious
that both implementations do the same thing?

We could even consolidate the code into a single function CheckProfileAccess() that takes
all 3 params, i.e. we have

CheckProfileAccess(user, QueryStateRecord);
CheckProfileAccess(user, ClientRequestState);
CheckProfileAccess(user, effective_user, has_access);

I don't fee too strongly, but seems nice to have the auth logic and error message only once.
File be/src/service/impala-server.h:

Line 639:     Status CheckProfileAccess(const std::string& user);
const fn
File fe/src/main/java/org/apache/impala/analysis/

Line 162:   private boolean enablePrivChecks_ = true;
I was hoping we could remove this now because it should have the same effect as setMaskPrivChecks(null).
Any reason we need to keep it?
File shell/

Line 515:       print_to_stderr(e)
are these changes for testing?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I2255d587367c2d328590ae8534a5406c4b0c9b15
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-HasComments: Yes

View raw message