impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laurel Hale (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4107 [DOCS] APPX MEDIAN cuts string to 10 chars
Date Wed, 07 Jun 2017 00:41:44 GMT
Laurel Hale has uploaded a new patch set (#3).

Change subject: IMPALA-4107 [DOCS] APPX_MEDIAN cuts string to 10 chars
......................................................................

IMPALA-4107 [DOCS] APPX_MEDIAN cuts string to 10 chars

In the "Restrictions" section of the "APPX_MEDIAN Function"
topic, added information about how the function truncates
string values: "The APPX_MEDIAN function returns only the
first 10 characters for string values (varchar, char).
Additional characters are truncated."

In this patch, I added 'string' to the list
of string values that are truncated by the APPX_MEDIAN
function and checked the source XML for the white space
called out in the review comment. It was not present in
the source. I can only speculate that it was a distortion
caused by the Gerrit UI.

Change-Id: I141787452e74ecdb491765cd7fd4c9a771c5bbc2
---
M docs/topics/impala_appx_median.xml
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/7094/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I141787452e74ecdb491765cd7fd4c9a771c5bbc2
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laurel Hale <laurel@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>

Mime
View raw message