impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8
Date Tue, 06 Jun 2017 20:11:05 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8
......................................................................


Patch Set 5:

> Many of these changes are essentially needed just for generating
 > consistent tests results when we switch between different java
 > versions. I wonder if this the right approach. We're essentially
 > "forcing" the use of a data structure with different
 > performance/memory tradeoffs than we had before. It may not have
 > significant impact on performance/memory usage, but creates
 > confusion. For example, I believe we may end up overusing linked*
 > just to ensure results stability. Wouldn't it be better is we made
 > the test results verification agnostic to order? Just some
 > thoughts...

When the order of some of these things change, the query execution can change which can affect
performance (though hopefully not correctness). I'd imagine we would want the order to remain
stable so as not to have performance regressions.

-- 
To view, visit http://gerrit.cloudera.org:8080/7073
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad8e1dccec3a51293a109c420bd2b88b9d1e0625
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message