impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1575: Yield admission control resources at query end
Date Tue, 06 Jun 2017 06:57:48 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-1575: Yield admission control resources at query end
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7079/1/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

Line 1114:   }
> Does Coordinator::ReleaseResources() really mean that all finstances' resou
you could view the admission control "tokens" as a resource, ie, there's a finite amount of
it and it's accounted for.

but the comment is a bit misleading, since the admission controller doesn't allocate actual
compute resources.

ReleaseResources() doesn't have any control over the instance resources.


-- 
To view, visit http://gerrit.cloudera.org:8080/7079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5003d017b3142a160bacf7e3569ff26026b1700
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message