impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5316: Adds last day() function
Date Tue, 06 Jun 2017 04:57:11 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5316: Adds last_day() function
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6991/4/be/src/exprs/timestamp-functions.h
File be/src/exprs/timestamp-functions.h:

PS4, Line 202:   ///   1) The argument cannot be implicitly casted to TIMESTAMP.
Remove this line. I don't think this is relevant to this function implementation (i.e. what
we're documenting in this header file) because you know the argument is already a TIMESTAMP.
It makes sense in the context of the commit msg and ultimately the Impala documentation.


-- 
To view, visit http://gerrit.cloudera.org:8080/6991
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I429c8734bddca3c37a2eedc211a16a4ffcb04370
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vincent Tran <vttran@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vttran@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message