impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit
Date Tue, 06 Jun 2017 02:07:54 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit
......................................................................


IMPALA-5433: Mark single-argument Status c'tors as explicit

Avoid unexpected errors by marking Status c'tors as explicit. Per Google
style guide, >1 arg c'tors are not marked as explicit to allow for
copy-initialization.

Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Testing: compiled impalad and be-test.
Reviewed-on: http://gerrit.cloudera.org:8080/7077
Reviewed-by: Henry Robinson <henry@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/common/status.h
M be/src/exec/hdfs-parquet-scanner.cc
M be/src/runtime/coordinator.cc
M be/src/util/codec.cc
4 files changed, 15 insertions(+), 16 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Henry Robinson: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>

Mime
View raw message