impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5438: Always eval union const exprs in subplan.
Date Tue, 06 Jun 2017 01:07:03 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-5438: Always eval union const exprs in subplan.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7091/1/testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
File testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test:

Line 592: ---- QUERY
> I think we should  validate the results  of this query. Maybe check the num
This test is crafted such that we expect an empty result set.
In the old buggy code, this query returned a non-empty result set. I verified that this test
fails without the fix.

I expanded the comment to explain what result we expect.


-- 
To view, visit http://gerrit.cloudera.org:8080/7091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd2f21f0213188e2304f8e9536019c7940c07768
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message