impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call
Date Tue, 06 Jun 2017 00:12:32 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-5388: Only retry RPC on lost connection in send call

Patch Set 3:


Will update the patch with new tests.
File be/src/rpc/

PS3, Line 186: write() send()
> As Henry mentioned, the retry is to handle transient failure. There are thr
As discussed offline, this is matching three specific exception cases in write_partial().
EAGAIN is translated to a timeout which may not be safe for retry.
File be/src/runtime/client-cache.h:

PS3, Line 256: VLOG(1)
> I think this trace and below one are redundant, the Status will log error, 
Yes, I was just preserving the pre-existing error logging we have in the code.

We can assemble a stringstream instead and pass it to Status constructor.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I176975f2aa521d5be8a40de51067b1497923d09b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <>
Gerrit-Reviewer: Alan Choi <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-Reviewer: Juan Yu <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message