impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5357: Fix unixtime to UTC TimestampValue perf
Date Mon, 05 Jun 2017 23:38:24 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5357: Fix unixtime to UTC TimestampValue perf
......................................................................


Patch Set 1:

(2 comments)

thanks for the review. I'll get this in once the boost version bump makes it in (currently
in gvo).

http://gerrit.cloudera.org:8080/#/c/7082/1/be/src/runtime/timestamp-value.cc
File be/src/runtime/timestamp-value.cc:

Line 140: /// again see IMPALA-5357). This called by UnixTimeToPtime.
> grammar
Done


Line 143:   const int64_t MIN_BOOST_CONVERT_UNIX_TIME = -9223372036;
> make public and reuse in test?
I'd prefer not to because I didn't want to have to expose these helper methods in the public
interface (they're just defined in the .cc file, not part of the class definition), it adds
4 more members to the class definition which makes the header a bit harder to read in my opinion.
I'm happy to do it though, if you'd still prefer.


-- 
To view, visit http://gerrit.cloudera.org:8080/7082
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d611d21310c7b4f93d8e0bc845eb85125abcac9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message