impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5357: Fix unixtime to UTC TimestampValue perf
Date Mon, 05 Jun 2017 23:38:24 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5357: Fix unixtime to UTC TimestampValue perf

Patch Set 1:


thanks for the review. I'll get this in once the boost version bump makes it in (currently
in gvo).
File be/src/runtime/

Line 140: /// again see IMPALA-5357). This called by UnixTimeToPtime.
> grammar

Line 143:   const int64_t MIN_BOOST_CONVERT_UNIX_TIME = -9223372036;
> make public and reuse in test?
I'd prefer not to because I didn't want to have to expose these helper methods in the public
interface (they're just defined in the .cc file, not part of the class definition), it adds
4 more members to the class definition which makes the header a bit harder to read in my opinion.
I'm happy to do it though, if you'd still prefer.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d611d21310c7b4f93d8e0bc845eb85125abcac9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <>
Gerrit-Reviewer: Attila Jeges <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>
Gerrit-HasComments: Yes

View raw message