impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call
Date Mon, 05 Jun 2017 19:57:23 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-5388: Only retry RPC on lost connection in send call

Patch Set 2:


Thanks for the reviews. Michael Brown ran the stress test in the secure cluster over the weekend
with this patch and he didn't find any wrong results so far. I also requested a stress test
run with the non-secure cluster.

For testing, I looked into the fault injection logic but didn't look into it in details.
File be/src/runtime/client-cache.h:

PS2, Line 252: else if 
> nit: avoid 'else' since previous block will return. Here and below.

PS2, Line 253: <F, Request, Response>
> can the compiler not figure out the specialization from the arguments?

PS2, Line 285: // If it's not timeout exception, then the connection is broken, stop retrying.
> Remove?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I176975f2aa521d5be8a40de51067b1497923d09b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <>
Gerrit-Reviewer: Alan Choi <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-Reviewer: Juan Yu <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message