impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5347: reduce codegen overhead of timestamp trunc()
Date Mon, 05 Jun 2017 19:23:20 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-5347: reduce codegen overhead of timestamp trunc()
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7081/1/be/src/exprs/udf-builtins-ir.cc
File be/src/exprs/udf-builtins-ir.cc:

PS1, Line 242: 
May make sense to codegen and constant propagate in this case.


http://gerrit.cloudera.org:8080/#/c/7081/1/be/src/exprs/udf-builtins.h
File be/src/exprs/udf-builtins.h:

PS1, Line 67: //
nit:///


-- 
To view, visit http://gerrit.cloudera.org:8080/7081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I222258f51b2093a38929df847fdb5d25bb9aafc3
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message